Sdk 3571 olly artifact changes #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanmay-Bstack
requested review from
osho-20,
karanshah-browserstack and
Copilot
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
osho-20
approved these changes
Aug 12, 2025
RutvikChandla
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
LGTM ✔️
Backward Compatibility: The changes properly handle legacy environment variables (BROWSERSTACK_TEST_OBSERVABILITY → BROWSERSTACK_TEST_REPORTING) through normalization functions
Clean Implementation: The normalizeTestReportingEnvVars() and normalizeTestReportingConfig() functions ensure existing configurations continue to work
Consistent Branding: All log messages and error outputs now use the unified "TEST REPORTING AND ANALYTICS" terminology
Non-Breaking: The changes appear to be additive rather than replacing existing functionality
karanshah-browserstack
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://browserstack.atlassian.net/browse/SDK-3571